Skip to content

[Bug] Success/Fail prometheus metrics inverted condition #175

@fabiormoura

Description

@fabiormoura

Hi,

I found two of the metrics sent to pushgateway with its boolean values flipped.

See snippet below where it happens:

https://github.com/appscode/stash/blob/e6065cb275eefd915ca4e68ae1a336f6510c091b/pkg/scheduler/scheduler.go#L289-L295

I believe the expected behaviour is having the success metric as 0 and fail as 1 when err != nil

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions