Add subscriptions for pre-confirmed transactions

[amanusk]

Changes

Checklist:

• Validated the specification files - npm run validate_all
• Applied formatting - npm run format
• [] Performed code self-review
• If making a new release, checked out the guidelines

[cchudant]

When using starknet_subscribeEvents with block_id: Latest and finality_status: PRE_CONFIRMED, we're supposed to return all events in the latest block before starting to return events in the pre-confirmed block, correct? ie. there's no way to tell the node to start from the pre-confirmed block
(not saying it's a bad or good thing, I'm just making sure I'm reading this right)

[amanusk]

Yes, as is the case in 0.8 with events of Pending transactions

[cchudant]

I think I'm missing why this field is an array instead of a string like starknet_subscribeEvents

[amanusk]

The idea was to allow to get only a subset of transaction, based on the finality you are looking fore. Only accepted_on_l2 if you don't want duplicates, and add pre_confirmed if more recent transactions are needed, and duplicates are acceptable

[kkovaacs]

BTW, do we really want to support the ACCEPTED_ON_L1 finality status here?

It'd be great if this subscribeNewTransactionReceipts and subscribeNewTransactions subscriptions would have the same semantics (and filtering capabilities).

[amanusk]

@kkovaacs, I agree. Supporting ACCEPTED_ON_L1 is not a good idea here; it can create a large batch of receipts received at once.

Re having the same semantics, we can have them as close as we can, but there are no receipts for CANDIDATE and RECEIVED so these would also be excluded from the options for receipts

[thiagodeev]

Here we are creating more exceptions than acceptance (3 out of 5 tags from the TXN_STATUS type are being excluded).
Why not use the TXN_FINALITY_STATUS instead, and only exclude the ACCEPTED_ON_L1 tag?

[amanusk]

Yes, good point.
I was trying to go for "this is the same as NewTransactions", but this is just not the case as receipts are not generated for CANDIDATE and RECEIVED transactions.
Fixed to your suggestion