Skip to content

Conversation

@AlbertoCasasOrtiz
Copy link
Collaborator

@AlbertoCasasOrtiz AlbertoCasasOrtiz commented Feb 13, 2025

Many changes here related to deploying so we should be extra careful.

This should be deployed with: stanfordnmbl/opencap-viewer#420

carmichaelong and others added 25 commits November 12, 2024 17:15
add mapping for genders in metadata
Add retry mechanism to many database requests
Intercepting error of human detection pose not detected in hrnet.
Dev: New deployment for new Server
@AlbertoCasasOrtiz AlbertoCasasOrtiz changed the title Update main main <- dev Feb 14, 2025
Copy link
Contributor

@carmichaelong carmichaelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes look safe and pretty well tested from before.

one question i have is probably more for @antoinefalisse: the change to checkerboard means that there are some strings for checkerBoardMount that will throw now when they didn't before (backWall_largeCB, backWall_walking, ground_jumps, ground_gaits. i assume this doesn't affect any new (or recent) trials. do you have any insight for what (older) trials might have issues with this? or was it all just used by you all internally from awhile ago?

@antoinefalisse
Copy link
Collaborator

@carmichaelong yeah these strings were there from when we were doing some testing a while ago. Never used through the web app.

Copy link
Contributor

@carmichaelong carmichaelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @antoinefalisse!

@AlbertoCasasOrtiz i think we're good to merge and then deploy across server, workstations, aws. and then we can monitor over the week.

@AlbertoCasasOrtiz AlbertoCasasOrtiz merged commit c10809f into main Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants