-
Notifications
You must be signed in to change notification settings - Fork 215
main <- dev #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main <- dev #231
Conversation
add mapping for genders in metadata
Add retry mechanism to many database requests
Intercepting error of human detection pose not detected in hrnet.
Lying checkerboard
…Retry error handling
Dev: New deployment for new Server
carmichaelong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes look safe and pretty well tested from before.
one question i have is probably more for @antoinefalisse: the change to checkerboard means that there are some strings for checkerBoardMount that will throw now when they didn't before (backWall_largeCB, backWall_walking, ground_jumps, ground_gaits. i assume this doesn't affect any new (or recent) trials. do you have any insight for what (older) trials might have issues with this? or was it all just used by you all internally from awhile ago?
|
@carmichaelong yeah these strings were there from when we were doing some testing a while ago. Never used through the web app. |
carmichaelong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @antoinefalisse!
@AlbertoCasasOrtiz i think we're good to merge and then deploy across server, workstations, aws. and then we can monitor over the week.
Many changes here related to deploying so we should be extra careful.
This should be deployed with: stanfordnmbl/opencap-viewer#420