[P1] Allowing interventions to take additional kwargs + module inputs (#215) #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a cherry-pick of changes from Peter's local try of implementing LoRA with pyvene backbone. main...peterwz-subspace
With this change, users can also provide additional intervention kwargs instead of overloading the
subspacesdict as we are doing right now.Concretely, if we currently doing this:
which is overloading
subspaces. We can now do:Testing Done
TBD
Checklist:
[Your Priority] Your Title