Skip to content

add linux nodeselector #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add linux nodeselector #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7c7faa
add linux nodeselector
timmy-wright Nov 7, 2025
ee45918
more node selector
timmy-wright Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deployments/kubernetes/chart/reloader/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ spec:
{{- end }}
{{- if .Values.reloader.deployment.nodeSelector }}
nodeSelector:
"kubernetes.io/os": linux
Copy link
Contributor

@msafwankarim msafwankarim Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of enforcing it in the chart, we should add this in values.yaml under reloader.deployment.nodeSelector by default. This will allow the user to override or unset it if they don't need it for any reason

{{ toYaml .Values.reloader.deployment.nodeSelector | indent 8 }}
{{- end }}
{{- if or (.Values.reloader.deployment.affinity) (.Values.reloader.enableHA) }}
Expand Down
7 changes: 7 additions & 0 deletions deployments/kubernetes/chart/reloader/tests/deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ templates:
- deployment.yaml

tests:
- it: sets nodeSelector to linux only
set:
asserts:
- equal:
path: spec.template.spec.nodeSelector."kubernetes.io/os"
value: linux

- it: sets readOnlyRootFilesystem in container securityContext when reloader.readOnlyRootFileSystem is true
set:
reloader:
Expand Down
2 changes: 2 additions & 0 deletions deployments/kubernetes/manifests/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ spec:
labels:
app: reloader-reloader
spec:
nodeSelector:
"kubernetes.io/os": linux
containers:
- image: "ghcr.io/stakater/reloader:v1.4.10"
imagePullPolicy: IfNotPresent
Expand Down
2 changes: 2 additions & 0 deletions deployments/kubernetes/reloader.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ spec:
labels:
app: reloader-reloader
spec:
nodeSelector:
"kubernetes.io/os": linux
containers:
- env:
- name: GOMAXPROCS
Expand Down
Loading