Skip to content

Conversation

@dguihal
Copy link

@dguihal dguihal commented Oct 1, 2025

Updated PR from #632

Fixes #603

@mahmadmujtaba
Copy link

Hey @dguihal Thanks for good work. To continue with this, can you assist us in:

  1. Adding further test cases to validate all introduced parameters for UptimeRobot.
  2. Generate an updated CRD reflecting the new types introduced. This will help us have a quick glance on updated CRD and new changes.
    2.1 make generate manifests command can support you on point 2.

@dguihal
Copy link
Author

dguihal commented Oct 30, 2025

Hi @mahmadmujtaba

I'll work on this

CRDs already updated

@mahmadmujtaba
Copy link

Hey @dguihal thanks for co-operation. We ran our pipeline on top of it and seems like linting has failed. Please can you look after it once more?

@dguihal
Copy link
Author

dguihal commented Nov 17, 2025

@mahmadmujtaba Seems those failures aren't related to my PR

I mean I can fix them, but I presume It would be better to have this done on a dedicated PR

Outside this, I'm quite stuck on unit testing of the changes because I don't find any appropriate target for POST requests, do you have any hint ?

Copie d'écran_20251117_111623

@mahmadmujtaba
Copy link

mahmadmujtaba commented Nov 20, 2025

hey @dguihal,

We can use this PR to fix linting issues and for your second question, try https://restful-api.dev/ service. This allows us to make empty POST requests to test.

curl --request POST \ --url https://api.restful-api.dev/objects \ --header 'Content-Type: application/json' \ --header 'User-Agent: insomnium/0.2.3-a' \ --data '{ "name": "Apple MacBook Pro 16", "data": { "year": 2019, "price": 1849.99, "CPU model": "Intel Core i9", "Hard disk size": "1 TB" } }

and response:

{ "id": "ff8081819782e69e019aa0aa67513443", "name": "Apple MacBook Pro 16", "createdAt": "2025-11-20T09:48:33.489+00:00", "data": { "year": 2019, "price": 1849.99, "CPU model": "Intel Core i9", "Hard disk size": "1 TB" } }

image

`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENHANCE] UptimeRobot all monitors features

3 participants