-
-
Notifications
You must be signed in to change notification settings - Fork 118
Add UptimeRobot all monitors features (updated) #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey @dguihal Thanks for good work. To continue with this, can you assist us in:
|
|
I'll work on this CRDs already updated |
|
Hey @dguihal thanks for co-operation. We ran our pipeline on top of it and seems like linting has failed. Please can you look after it once more? |
|
@mahmadmujtaba Seems those failures aren't related to my PR I mean I can fix them, but I presume It would be better to have this done on a dedicated PR Outside this, I'm quite stuck on unit testing of the changes because I don't find any appropriate target for POST requests, do you have any hint ?
|
|
hey @dguihal, We can use this PR to fix linting issues and for your second question, try https://restful-api.dev/ service. This allows us to make empty POST requests to test.
and response:
` |


Updated PR from #632
Fixes #603