Skip to content

Conversation

@sachaudh
Copy link
Contributor

@sachaudh sachaudh commented Dec 2, 2025

Description

This PR fixes the dashboard-related tests. Looks like I ended up checking the Vuln Mgmt, Config Mgmt, and Compliance Dashboard tests too. Those dashboards behave a bit oddly in v6 though, so I'll fix the UI errors when I get to those sections.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Screenshot 2025-12-02 at 9 35 54 AM Screenshot 2025-12-02 at 9 30 47 AM

@sachaudh sachaudh requested a review from a team as a code owner December 2, 2025 17:32
@sachaudh sachaudh force-pushed the saif/ROX-31772-fix-dashboard-page branch from f535228 to c7f93e0 Compare December 2, 2025 17:41
@sachaudh sachaudh force-pushed the saif/ROX-31770-fix-share-feedback-modal branch from b0361e7 to da76cd0 Compare December 4, 2025 01:47
@sachaudh sachaudh requested a review from a team as a code owner December 4, 2025 01:47
@sachaudh sachaudh force-pushed the saif/ROX-31772-fix-dashboard-page branch from c7f93e0 to 16a724b Compare December 4, 2025 01:48
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.35%. Comparing base (da76cd0) to head (16a724b).

Additional details and impacted files
@@                             Coverage Diff                             @@
##           saif/ROX-31770-fix-share-feedback-modal   #18022      +/-   ##
===========================================================================
- Coverage                                    49.35%   49.35%   -0.01%     
===========================================================================
  Files                                         2699     2699              
  Lines                                       198960   198960              
===========================================================================
- Hits                                         98201    98196       -5     
- Misses                                       93142    93146       +4     
- Partials                                      7617     7618       +1     
Flag Coverage Δ
go-unit-tests 49.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants