Support explicitly specifying the boto3utils3.s3 object#92
Merged
Conversation
…upport explicitly specifying the boto3utils3.s3 object
gadomski
approved these changes
Mar 8, 2024
ircwaves
approved these changes
Mar 8, 2024
Member
ircwaves
left a comment
ircwaves
left a comment
There was a problem hiding this comment.
Excellent added flexibility. 👍🏽
Question/suggestion: what about moving the s3_client parameter from the signature of Task.upload_item_assets_to_s3 to the constructor, and have the if None defaulting to self._s3_client = s3() happen there? Then upload_item_assets_to_s3 could use self._s3_client, and potentially/eventually download_item_assets could too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task.upload_item_assets_to_s3 and asset_io.upload_item_assets_to_s3 support explicitly specifying the boto3utils3.s3 object
This allows greater flexibility in setting various AWS S3 parameters, which allows this to support S3-compatible APIs like MinIO.