Skip to content

Don't remove workdir by default if user specified#51

Merged
gadomski merged 1 commit into
mainfrom
jak/no-rm-workdir
Nov 6, 2023
Merged

Don't remove workdir by default if user specified#51
gadomski merged 1 commit into
mainfrom
jak/no-rm-workdir

Conversation

@jkeifer
Copy link
Copy Markdown
Member

@jkeifer jkeifer commented Nov 3, 2023

When a workdir is set for a Task the workdir will no longer be removed by default. That is, the save_workdir argument to Task constructor now defaults to None, and if left as None the default behavior is now conditional on whether or not a workdir is specified:

  • If workdir is None, a temp directory will be created and save_workdir will default to False (remove working directory).
  • If a workdir is specified, then save_workdir will default to True (keep working directory).

In either case, an explicit True or False value for save_workdir will take precedence.

@gadomski gadomski merged commit 8d8c566 into main Nov 6, 2023
@gadomski gadomski deleted the jak/no-rm-workdir branch November 6, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants