Allow intersects search to use GeometryCollection #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
requested changes
Mar 24, 2023
Member
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Should include a unit test for both backends and a CHANGELOG entry.
jpolchlo
force-pushed
the
fix/intersects-geometrycollection
branch
from
8231715 to
229bcd3
Compare
… made with a GeometryCollection type to the 'intersects' query without raising a 400 error; has not been tested to show that the intersection is correct
jpolchlo
force-pushed
the
fix/intersects-geometrycollection
branch
from
229bcd3 to
f97bc49
Compare
gadomski
previously requested changes
May 9, 2023
Member
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
This will need to be updated to have a no-backend test, if possible.
Collaborator
Member
Not really — since it's just adding a type to a
FYSA @jpolchlo isn't working the project that was using this repo anymore, so he may not have bandwidth to fix (in case he doesn't respond). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Closes #187
Description:
An apparent oversight omitted GeometryCollection from the list of valid geometry types for intersection queries. This PR remedies this.
PR Checklist:
pre-commithooks pass locallymake test)make docs)