Fix loading of example data in docker compose#142
Merged
vincentsarago merged 4 commits intostac-utils:mainfrom Aug 21, 2024
Merged
Fix loading of example data in docker compose#142vincentsarago merged 4 commits intostac-utils:mainfrom
vincentsarago merged 4 commits intostac-utils:mainfrom
Conversation
vincentsarago
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
When trying to load the example data I was getting an error that the requests package was not found. This is because in
setup.py, the server only requiresuvicorn. I updated docker compose somake run-joplinnow succeeds.PR Checklist:
pre-commithooks pass locallymake test)make docs)