Pass href to item constructor in from_dict#984
Merged
Conversation
gadomski
changed the title
Codecov ReportBase: 90.28% // Head: 90.32% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
==========================================
+ Coverage 90.28% 90.32% +0.03%
==========================================
Files 47 47
Lines 6137 6137
Branches 915 915
==========================================
+ Hits 5541 5543 +2
+ Misses 414 413 -1
+ Partials 182 181 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pjhartzell
approved these changes
Feb 14, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
gadomski
force-pushed
the
issues/801-normalize-hrefs
branch
from
c9567a8 to
bc87db1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Turns out the fix was simple --
hrefwasn't getting passed fromItem.from_dictto the Item constructor.PR Checklist:
pre-commit run --all-files)scripts/test)