Generalize return types from classmethods#983
Merged
Conversation
8f323d7 to
da6f665
Compare
pjhartzell
requested changes
Feb 13, 2023
Collaborator
pjhartzell
left a comment
There was a problem hiding this comment.
Looks good. Just a few questions.
pjhartzell
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
cloneshouldn't hard-code return type #863Description:
Use
TypeVarfor alternate constructors, e.g.from_dictandfrom_file. The keycastthat enables the whole inheritance tree to work is https://github.com/stac-utils/pystac/compare/issues/862-return-types?expand=1#diff-3f0f0b208e42045d63bb010a3b963e4178a8cf882f75f73d8392828b2190eafcR525.Includes some sidecar fixes:
clonein a couple of places where it was missing, closingcloneshouldn't hard-code return type #863from __future__ import annotationsopportunities that were missed in Usefrom __future__ import annotations#962PR Checklist:
pre-commit run --all-files)scripts/test)