Correct invalid html generated by _repr_html_() #975
Merged
Conversation
- this fixes the incorrect html and missing link targets - bug caused by link.target's preference to return the resolved STAC object rather than the target href string
- consistent: all lowercase; prior was a mix of capitalized and uncapitalized - match JSON: things like 'bbox' instead of 'bounding box' and 'type' instead of 'media type' for a 1:1 with the JSON
- addresses the extra_field 'properties' containing a blank dictionary
… titles - reorder: basically, make field ordering more consistent between assets and links - remove link heading: the existing link heading was only populated when a title existed, and, IMO, looked awkward. I moved the title to the heading to be consistent with the asset structure - guard against missing titles: no longer display 'None' in the asset heading when there is no title
pjhartzell
changed the title
_repr_html_()
Codecov ReportBase: 90.09% // Head: 90.21% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 90.09% 90.21% +0.11%
==========================================
Files 47 47
Lines 6090 6090
Branches 915 915
==========================================
+ Hits 5487 5494 +7
+ Misses 422 414 -8
- Partials 181 182 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gadomski
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
_repr_html_()#955Description:
Fixes a few bugs and makes the display formatting more consistent.
Fixes:
<strong>tag added to Catalog idNoneis no longer displayed in Asset heading when the Asset does not have a title.{}, when they exist in extra_fieldsFormats:
bboxin place ofBounding Box,typein place ofMedia Type, andhrefin place ofTargetfor a 1:1 with the JSON fields.PR Checklist:
pre-commit run --all-files)scripts/test)For comparison to the image in issue #955:
