Add flatgeobuf media type#938
Conversation
Codecov ReportBase: 94.37% // Head: 94.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 83 83
Lines 12015 12016 +1
Branches 1136 1136
=======================================
+ Hits 11339 11340 +1
Misses 496 496
Partials 180 180
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gadomski
left a comment
There was a problem hiding this comment.
Per flatgeobuf/flatgeobuf#112 (comment), it seems like there's still an open question of the "correct" media type -- @m-mohr's suggestion in that comment is application/vnd.flatgeobuf, but this PR uses application/flatgeobuf. I'm hesitant to approve w/o input form @m-mohr or someone else who might have guidance on the best one to pick for PySTAC.
|
I think this must be approved by the official maintainer of flatgeobuf, all other attempts from "unofficial" side just leads to issues later on, like with GeoTiff/COG where the whole community uses what we invented for STAC, but in the end we figured out that this can't be the official media type from OGC (or IANA). |
|
I've asked for guidance from the flatgeobuf folks at flatgeobuf/flatgeobuf#112 (reply in thread). Marking this PR as a draft until that question is settled. |
|
@pjhartzell per flatgeobuf/flatgeobuf#112 (reply in thread), can you update to |
ac2d617 to
7028027
Compare
|
@gadomski Updated. |
|
Are we good with the enum name |
MediaType selection discussion: flatgeobuf/flatgeobuf#112 (reply in thread)
7028027 to
7bd822a
Compare
|
flatgeobuf/flatgeobuf#112 (reply in thread) feels like Good Enough™ to me -- marking this as ready to review. |
|
@gadomski Discussion link now in comment and changelog. 🙂 |
Related Issue(s):
#763
Description:
Adds a media type for flatgeobuf data.
PR Checklist:
pre-commit run --all-files)scripts/test)