Fix dependencies#897
Merged
Merged
Conversation
This was causing a dependency resolution conflict, uncaught by CI.
1604885 to
19051f8
Compare
This would have caught the doc8 dependency resolution problem.
19051f8 to
e888360
Compare
TomAugspurger
approved these changes
Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Should unblock #895, #882, and others.
Description:
Dependency resolution was broken for
pip install -r requirements-dev.txt:$ pip install -r requirements-dev.txt ... snip ... ERROR: Cannot install -r ./requirements-docs.txt (line 2), -r ./requirements-docs.txt (line 4), -r ./requirements-docs.txt (line 5), -r ./requirements-docs.txt (line 6) and -r ./requirements-test.txt (line 9) because these package versions have conflicting dependencies. The conflict is caused by: sphinx 4.5.0 depends on docutils<0.18 and >=0.14 nbsphinx 0.8.9 depends on docutils pydata-sphinx-theme 0.8.1 depends on docutils!=0.17.0 sphinx-panels 0.6.0 depends on docutils doc8 1.0.0 depends on docutils<0.21 and >=0.19This wasn't caught by CI because we never install
requirements-dev.txton CI. This PR:requirements-dev.txtinstallPR Checklist:
pre-commit run --all-files)scripts/test)