Skip to content

Fix the "how to create STAC catalogs" tutorial#775

Merged
duckontheweb merged 4 commits into
mainfrom
issues/771-fix-tutorial
Mar 30, 2022
Merged

Fix the "how to create STAC catalogs" tutorial#775
duckontheweb merged 4 commits into
mainfrom
issues/771-fix-tutorial

Conversation

@gadomski
Copy link
Copy Markdown
Member

@gadomski gadomski commented Mar 29, 2022

Related Issue(s):

Description: Fixes the how-to-create-stac-catalogs tutorial to use the new extension syntax. Also includes:

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 29, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.55%. Comparing base (3209bf8) to head (3f88cde).
⚠️ Report is 693 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          79       79           
  Lines       11647    11647           
  Branches     1372     1372           
=======================================
  Hits        11013    11013           
  Misses        455      455           
  Partials      179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gadomski gadomski force-pushed the issues/771-fix-tutorial branch from ee7beed to c836cf7 Compare March 29, 2022 13:25
Comment thread .pre-commit-config.yaml Outdated
@gadomski gadomski force-pushed the issues/771-fix-tutorial branch from c836cf7 to 801fbfe Compare March 30, 2022 14:27
Copy link
Copy Markdown
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @gadomski !

@duckontheweb duckontheweb merged commit 443828f into main Mar 30, 2022
@duckontheweb duckontheweb deleted the issues/771-fix-tutorial branch March 30, 2022 15:20
@duckontheweb duckontheweb added this to the 1.5.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in pystac/docs/tutorials/how-to-create-stac-catalogs.ipynb

3 participants