Skip to content

Fix paths to saved sub-catalogs#714

Merged
duckontheweb merged 2 commits into
stac-utils:mainfrom
duckontheweb:fix/713-sub-catalog-save-paths
Jan 18, 2022
Merged

Fix paths to saved sub-catalogs#714
duckontheweb merged 2 commits into
stac-utils:mainfrom
duckontheweb:fix/713-sub-catalog-save-paths

Conversation

@duckontheweb
Copy link
Copy Markdown
Contributor

@duckontheweb duckontheweb commented Jan 15, 2022

Related Issue(s):

Description:

Fixes the paths to which sub-catalogs are saved by ensuring that the dest_href argument to Catalog.save is a directory when called on child catalogs.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from gadomski January 15, 2022 11:51
@duckontheweb duckontheweb added this to the 1.3.0 milestone Jan 15, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 15, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.31%. Comparing base (70faaa5) to head (f79f8ee).
⚠️ Report is 738 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
+ Coverage   94.30%   94.31%   +0.01%     
==========================================
  Files          77       77              
  Lines       11249    11269      +20     
  Branches     1342     1344       +2     
==========================================
+ Hits        10608    10628      +20     
  Misses        461      461              
  Partials      180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@duckontheweb
Copy link
Copy Markdown
Contributor Author

cc: @KennSmithDS

@duckontheweb duckontheweb merged commit b136f25 into stac-utils:main Jan 18, 2022
@duckontheweb duckontheweb deleted the fix/713-sub-catalog-save-paths branch January 18, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect path to saved sub-catalogs

3 participants