Add note on possible exceptions to extensions docs#701
Merged
duckontheweb merged 2 commits intoJan 14, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## main #701 +/- ##
=======================================
Coverage 94.30% 94.30%
=======================================
Files 77 77
Lines 11249 11249
Branches 1342 1342
=======================================
Hits 10608 10608
Misses 461 461
Partials 180 180 Continue to review full report at Codecov.
|
|
I think that looks good! Thanks :-) |
alexgleith
approved these changes
Jan 7, 2022
duckontheweb
added a commit
to duckontheweb/pystac
that referenced
this pull request
Jan 14, 2022
ed47631 to
5d3ea79
Compare
5d3ea79 to
f2408e8
Compare
lossyrob
approved these changes
Jan 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Adds a note to the Concepts docs describing how to access extension properties that makes it more clear that
.extwill raise an exception if the object does not already implement the extension.PR Checklist:
pre-commit run --all-files)scripts/test)