Update docs, tests, summaries for stable extensions#372
Merged
duckontheweb merged 17 commits intoJun 2, 2021
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
+ Coverage 89.43% 89.69% +0.26%
==========================================
Files 39 39
Lines 5063 5154 +91
==========================================
+ Hits 4528 4623 +95
+ Misses 535 531 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Yeah, maybe "v" is better as "s" on citation. We had the case where we had a regexp for the year number in the citation summary, which would be a use case. But I agree that in general, a list of values is probably the better option. Opened PR stac-utils/stac-fields#11 for it. |
m-mohr
added a commit
to stac-utils/stac-fields
that referenced
this pull request
May 28, 2021
m-mohr
added a commit
to stac-utils/stac-fields
that referenced
this pull request
May 28, 2021
* Use default behavior (list of values) instead of schema Origin: stac-utils/pystac#372
lossyrob
reviewed
Jun 1, 2021
lossyrob
approved these changes
Jun 1, 2021
Member
lossyrob
left a comment
There was a problem hiding this comment.
Looking good, couple of suggestions but overall +1
...for consistency with EO extension after stac-utils#377
11 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #
Description:
view,projection, andscientificextensionsdoian optional argument forScientificExtensionandPublicationto match specview,projection, andscientificextensionsstac-fieldsindicates that JSON Schema format should be used forsci:citationsummaries, but using a simple list seemed more appropriate, so that's how I implemented it for now. @m-mohr @matthewhanson Maybe you have more insight around the rationale for using the JSON Schema summaries for that field?PR Checklist:
scripts/format)scripts/test)