Skip to content

Add netCDF in the media types list#1386

Merged
gadomski merged 2 commits into
stac-utils:mainfrom
clausmichele:add_netcdf_media_type
Aug 6, 2024
Merged

Add netCDF in the media types list#1386
gadomski merged 2 commits into
stac-utils:mainfrom
clausmichele:add_netcdf_media_type

Conversation

@clausmichele
Copy link
Copy Markdown
Contributor

@clausmichele clausmichele commented Aug 6, 2024

Description:

The media type for netCDF files was missing from the pystac.media_type class. It is already used in a test file here:

"type": "application/netcdf",

Sample public STAC Collection using this media type: https://planetarycomputer.microsoft.com/api/stac/v1/collections/nasa-nex-gddp-cmip6/items

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski enabled auto-merge August 6, 2024 13:28
@gadomski gadomski added this pull request to the merge queue Aug 6, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (c77412e) to head (a5f18c6).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1386   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          51       51           
  Lines        7220     7221    +1     
  Branches     1018     1018           
=======================================
+ Hits         6591     6592    +1     
  Misses        450      450           
  Partials      179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into stac-utils:main with commit a88906b Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants