Add convenience method for accessing pystac_client#1365
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 91.28% 91.19% -0.10%
==========================================
Files 51 52 +1
Lines 7221 7234 +13
Branches 1018 1019 +1
==========================================
+ Hits 6592 6597 +5
- Misses 450 457 +7
- Partials 179 180 +1 ☔ View full report in Codecov by Sentry. |
|
I can either ignore this file in coverage or I can try to figure out a test for the the case where pystac_client is not importable. |
gadomski
left a comment
There was a problem hiding this comment.
I'm not to stressed about coverage, but I do think some sort of CI check to make sure we work with and without pystac-client installed would be good ... this would be an easy thing to break inadvertently. Also, can you add a quick docs section describing how to use the import? 🙇🏼
|
All right! I ended up ignoring mypy. Mypy passes if pystac_client is installed, but it didn't seem worth it to try to mock out a stub or something. Another option I suppose would be to add pystac_client as a test requirement, but that might not be desirable. |
|
Love it! Thank you 🙏 |

Related Issue(s):
from pystac.client import Client#1334Description:
PR Checklist:
pre-commithooks pass locallyscripts/test)