Skip to content

Make get_all_collections properly recursive#1361

Merged
gadomski merged 3 commits into
stac-utils:mainfrom
jsignell:fix/get_all_collections
Jul 8, 2024
Merged

Make get_all_collections properly recursive#1361
gadomski merged 3 commits into
stac-utils:mainfrom
jsignell:fix/get_all_collections

Conversation

@jsignell
Copy link
Copy Markdown
Member

@jsignell jsignell commented Jul 5, 2024

Related Issue(s):

Description:

The docstring states that this method is meant to traverse subcatalogs recursively.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (52d59b3) to head (ba1f397).
Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1361   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files          51       51           
  Lines        7042     7042           
  Branches     1008     1008           
=======================================
  Hits         6424     6424           
  Misses        443      443           
  Partials      175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a ## Fixed changelog entry

@gadomski gadomski added this pull request to the merge queue Jul 8, 2024
Merged via the queue into stac-utils:main with commit a2a8e5b Jul 8, 2024
@jsignell jsignell deleted the fix/get_all_collections branch July 9, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_all_collections only goes one level deeper

2 participants