Deprecate the label extension#1270
Merged
Merged
Conversation
gadomski
force-pushed
the
issues/1249-deprecate-label
branch
2 times, most recently
from
a2804b2 to
7e2a8e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
gadomski
force-pushed
the
issues/1249-deprecate-label
branch
from
00b8f1e to
a8c3cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
I kept the hooks in place (
__init__.py) because the label extension adds a new object link rel type,"source". Removing that hook would change behavior, so we keep it until we make a breaking change to remove the extension altogether.I also removed the label extension from all tutorials, and added some notebook-required dependencies to the
docoptional dependency group.PR Checklist:
pre-commithooks pass locallyscripts/test)