Expand get_items - deprecate get_all_items and Catalog.get_item #1075
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 47 47
Lines 6227 6230 +3
Branches 935 934 -1
=======================================
+ Hits 5620 5623 +3
Misses 427 427
Partials 180 180 ☔ View full report in Codecov by Sentry. |
get_items - deprecate get_all_items and Catalog.get_item get_items - deprecate get_all_items and Catalog.get_item
gadomski
requested changes
Apr 3, 2023
Member
There was a problem hiding this comment.
Just two minor notebook fixups, otherwise looks good to me. I'm going to ask for another set of eyes on this one, just because it's a non-insignificant API change we're committing too, and I want to make sure it makes sense to someone else.
Oh, needs a CHANGELOG as well.
Co-authored-by: Pete Gadomski <[email protected]>
gadomski
approved these changes
Apr 3, 2023
TomAugspurger
approved these changes
Apr 3, 2023
Collaborator
TomAugspurger
left a comment
There was a problem hiding this comment.
Makes sense to me.
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Instead of using
get_all_itemspeople should useget_items(recursive=True)and instead ofCatalog.get_item(id)people should usenext(Catalog.get_items(id), None)TO DO:
PR Checklist:
pre-commithooks pass locallyscripts/test)