Fix __geo_interface__#1049
Merged
Merged
Conversation
5a3e722 to
efc0373
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 47 47
Lines 6213 6213
Branches 929 929
=======================================
Hits 5613 5613
Misses 422 422
Partials 178 178 ☔ View full report in Codecov by Sentry. |
c9dfe79 to
6b65681
Compare
philvarner
reviewed
Mar 21, 2023
Collaborator
|
I think returning every field (instead of just the required GeoJSON Feature fields) is the correct behavior. |
a4cfc77 to
1cd25e7
Compare
philvarner
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
__geo_interface__should be the feature, not just the geometry. I misread the protocol on my first implementation. I made the choice to just callto_dictwith all the dials set to no to make it as quick and light as possible. An alternative implementation would be to build a new dict with only the__geo_interface__required fields (type,bbox,properties,geometry,coordinates).PR Checklist:
pre-commithooks pass locallyscripts/test)