Move TemplateError to errors.py#1018
Merged
Merged
Conversation
gadomski
requested changes
Feb 28, 2023
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
==========================================
- Coverage 90.32% 90.30% -0.03%
==========================================
Files 47 47
Lines 6184 6189 +5
Branches 929 929
==========================================
+ Hits 5586 5589 +3
- Misses 420 422 +2
Partials 178 178
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gadomski
approved these changes
Mar 1, 2023
- add missing requirement - update the livehtml option
gadomski
force-pushed
the
issues/686-template-error
branch
from
24d7ccd to
beb882c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Duplicates
TemplateErrorfromlayout.pytoerrors.pyand updates all references to point to the definition inerrors.py. All custom exceptions are now inerrors.py. Per #685, the existingTemplateErrorremains inlayout.pybut is now marked as deprecated and noted that it will be removed in the next major release (2.0.0).PR Checklist:
pre-commit run --all-files)scripts/test)