Skip to content

Unpin urllib3 in dev dependencies#517

Closed
jsignell wants to merge 7 commits into
stac-utils:mainfrom
jsignell:unpin-urllib3
Closed

Unpin urllib3 in dev dependencies#517
jsignell wants to merge 7 commits into
stac-utils:mainfrom
jsignell:unpin-urllib3

Conversation

@jsignell
Copy link
Copy Markdown
Member

Related Issue(s):

Description:
See if unpinning works now that some time has passed.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@jsignell jsignell marked this pull request as draft May 15, 2023 14:18
@jsignell
Copy link
Copy Markdown
Member Author

Doesn't pass yet.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2398500) 88.34% compared to head (c2717b4) 88.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files          13       13           
  Lines         987      987           
=======================================
  Hits          872      872           
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski changed the title Unpin urllib3 Unpin urllib3 in dev dependencies Jun 7, 2023
@gadomski gadomski linked an issue Aug 21, 2023 that may be closed by this pull request
@gadomski
Copy link
Copy Markdown
Member

Still no 😞

@gadomski
Copy link
Copy Markdown
Member

gadomski commented Aug 2, 2024

I think we'll be able to fix this after we drop Python 3.9 — I've started that process over in PySTAC in stac-utils/pystac#1384.

@gadomski
Copy link
Copy Markdown
Member

OBE #719

@gadomski gadomski closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

urllib3 release breaks tests

3 participants