fix: enable sidechain insertion for pruned ancestors #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eomti-wm
requested review from
0xmhha,
code0xff,
colinkim,
egonspace and
hominlee-wemade
egonspace
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sync recovery after abnormal termination
Summary
Enables state recovery for blocks with missing state tries (e.g., after
kill -9) by falling back to sidechain insertion logic instead of discarding them.Details
ErrPrunedAncestorcaused by missing state after abnormal shutdown triggered immediate block discard, permanently blocking sync.insertSideChain()to handle these cases.insertSideChain()detects the need for reorg and executes its internal state recovery logic, allowing the node to heal the chain state automatically.