Skip to content

Replace Queue<byte> based buffer by array based buffer in PipeStream. #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zwergenaufstand wants to merge 1 commit into from
Closed

Replace Queue<byte> based buffer by array based buffer in PipeStream. #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/Renci.SshNet.Tests/Classes/Common/PipeStreamTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,18 +175,6 @@ public void LengthTest()
Assert.AreEqual(0L, target.Length);
}

/// <summary>
///A test for MaxBufferLength
///</summary>
[TestMethod]
public void MaxBufferLengthTest()
{
var target = new PipeStream();
Assert.AreEqual(200 * 1024 * 1024, target.MaxBufferLength);
target.MaxBufferLength = 0L;
Assert.AreEqual(0L, target.MaxBufferLength);
}

[TestMethod]
public void Position_GetterAlwaysReturnsZero()
{
Expand Down
2 changes: 1 addition & 1 deletion src/Renci.SshNet.Tests/Classes/Common/PipeStream_Close_BlockingWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class PipeStream_Close_BlockingWrite
[TestInitialize]
public void Init()
{
_pipeStream = new PipeStream {MaxBufferLength = 3};
_pipeStream = new PipeStream(3);

Action writeAction = () =>
{
Expand Down
12 changes: 2 additions & 10 deletions src/Renci.SshNet.Tests/Classes/PipeStreamTest_Dispose.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,9 @@ public void Flush_ShouldThrowObjectDisposedException()
}

[TestMethod]
public void MaxBufferLength_Getter_ShouldReturnTwoHundredMegabyte()
public void BufferLength_Getter_ShouldReturnOneMegabyte()
{
Assert.AreEqual(200 * 1024 * 1024, _pipeStream.MaxBufferLength);
}

[TestMethod]
public void MaxBufferLength_Setter_ShouldModifyMaxBufferLength()
{
var newValue = new Random().Next(1, int.MaxValue);
_pipeStream.MaxBufferLength = newValue;
Assert.AreEqual(newValue, _pipeStream.MaxBufferLength);
Assert.AreEqual(1024 * 1024, _pipeStream.BufferLength);
}

[TestMethod]
Expand Down
Loading