ReadToEndAsync no longer works on shellstream

[spektor56]

When calling ReadToEndAsync a StreamReader for the ShellStream in the ShellStreamOnDataReceived event, the request hangs and never returns.

it is due to this block in the read method:

while (_readBuffer.ActiveLength == 0 && !_disposed)
{
_ = Monitor.Wait(_sync);
}

the method never returns 0 so ReadToEnd never completes.

[Rob-Hague]

please post some example code? the stream ends (Read returns 0) once the shell is closed/disposed. Perhaps ShellStream.Read() (without parameters) fits what you are after? See also #1485

[spektor56]

Example:

var shellStream = SshClient.CreateShellStream("xterm-256color", 0, 0, 0, 0, 1024);
var streamReader = new StreamReader(shellStream);
var terminalText = await streamReader.ReadToEndAsync().ConfigureAwait(false);

worked fine in previous version, in more recent versions it gets stuck in the readtoendasync call

[Rob-Hague]

yeah so StreamReader.ReadToEndAsync blocks until the stream ends. In earlier versions ShellStream would report ending prematurely which was later fixed. You can try ShellStream.Read/ReadLine(TimeSpan timeout)/Expect(...)

[spektor56]

Makes sense, guess readtoend should have never worked for this case since read should never return 0 bytes until the connection is closed.

I was just using the data available event and reading everything every time the event fired.