refactor(core): cleanup deprecated SM api usage#19
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the WeaponCleaner SourceMod plugin to remove redundant SDKHooks unhooking on client disconnect, aligning with SDKHook’s documented behavior (automatic unhook on entity destruction) and bumps the plugin version.
Changes:
- Bump plugin version from
2.2.2to2.2.3. - Remove explicit
SDKUnhookcalls inOnClientDisconnect()for weapon drop/equip hooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleanup of deprecated and unnecessary SourceMod API usage across plugins.
Changes
SDKUnhook— hooks are automatically removed on entity destruction per SDKHook documentationReferences