Skip to content

refactor(core): improve code readability #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rushaway merged 1 commit into from
Feb 13, 2026
Merged

refactor(core): improve code readability #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions addons/sourcemod/scripting/PotcVote.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public Plugin myinfo =
name = "PotcVoteSystem",
author = "Neon, maxime1907, .Rushaway",
description = "Vote system for Potc",
version = "1.4.1",
version = "1.4.2",
url = "https://steamcommunity.com/id/n3ontm"
}

Expand All @@ -25,8 +25,7 @@ bool g_bIsRevote = false;
bool bStartVoteNextRound = false;
bool g_bOnCooldown[NUMBEROFSTAGES];

ConVar g_cDelay;
ConVar g_cPercent;
ConVar g_cDelay, g_cPercent;

static char g_sStageName[NUMBEROFSTAGES][512] = {"Classic", "Extreme", "Race Mode"};
int g_Winnerstage;
Expand Down Expand Up @@ -110,7 +109,7 @@ public void OnRoundStart(Event event, const char[] name, bool dontBroadcast)
if (bStartVoteNextRound)
{
delete g_CountdownTimer;
g_CountdownTimer = CreateTimer(1.0, StartVote, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
g_CountdownTimer = CreateTimer(1.0, StartVote_Timer, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
bStartVoteNextRound = false;
}

Expand All @@ -134,7 +133,7 @@ public void OnRoundStart(Event event, const char[] name, bool dontBroadcast)
DispatchKeyValue(iNewGameText, "fadein", "1");
DispatchKeyValue(iNewGameText, "fadeout", "1");
DispatchKeyValue(iNewGameText, "holdtime", "30");
DispatchKeyValue(iNewGameText, "message", "“If you were waiting for the opportune moment, that was it.” -Jack Sparrow");
DispatchKeyValue(iNewGameText, "message", "“If you were waiting for the opportune moment, that was it.” - Jack Sparrow");
DispatchKeyValue(iNewGameText, "x", "-1");
DispatchKeyValue(iNewGameText, "y", ".01");
DispatchKeyValue(iNewGameText, "OnUser1", "!self,Display,,0,-1");
Expand Down Expand Up @@ -244,7 +243,7 @@ public void Cmd_CancelVote()
CPrintToChatAll("{green}[PotcVote] {cyan}Zombies detected, aborting vote!");
}

public Action StartVote(Handle timer)
public Action StartVote_Timer(Handle timer)
{
static int iCountDown = 3;
PrintCenterTextAll("[PotcVote] Starting Vote in %ds", iCountDown);
Expand All @@ -266,7 +265,7 @@ public void InitiateVote()
{
CPrintToChatAll("{green}[PotcVote] {white}Another vote is currently in progress, retrying again in 5s.");
delete g_CountdownTimer;
g_CountdownTimer = CreateTimer(5.0, StartVote, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
g_CountdownTimer = CreateTimer(5.0, StartVote_Timer, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
return;
}

Expand Down Expand Up @@ -333,7 +332,7 @@ public void Handler_SettingsVoteFinished(Handle menu, int num_votes, int num_cli
g_bIsRevote = true;

delete g_CountdownTimer;
g_CountdownTimer = CreateTimer(1.0, StartVote, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
g_CountdownTimer = CreateTimer(1.0, StartVote_Timer, INVALID_HANDLE, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);

return;
}
Expand Down Expand Up @@ -411,7 +410,7 @@ public int FindEntityByTargetname(int entity, const char[] sTargetname, const ch
return INVALID_ENT_REFERENCE;
}

void TerminateRound()
stock void TerminateRound()
{
CS_TerminateRound(g_cDelay.FloatValue, CSRoundEnd_Draw, false);

Expand Down