Skip to content

fix(ripext): silent failure #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rushaway merged 3 commits into from
Mar 3, 2026
Merged

fix(ripext): silent failure #21

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8aa0dc6
fix(ripext): memory leak
Rushaway Mar 3, 2026
37ea624
Log error on JSON parsing failure in FixNetPublicAdr
Rushaway Mar 3, 2026
6ac636a
Remove unnecessary delete of jsonIP
Rushaway Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion addons/sourcemod/scripting/FixNetPublicAdr.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public Plugin myinfo =
name = "FixNetPublicAddr",
author = "maxime1907, .Rushaway",
description = "Add/Edit convar net_public_adr for servers behind NAT/DHCP",
version = "1.1.1",
version = "1.1.2",
url = ""
};

Expand Down Expand Up @@ -81,7 +81,11 @@ void OnPublicIPReceived(HTTPResponse response, any value)
return;

JSONObject jsonIP = view_as<JSONObject>(response.Data);
if (jsonIP == null)
return;

jsonIP.GetString("ip", g_sPublicIPAddress, sizeof(g_sPublicIPAddress));
delete jsonIP;

g_cvNetPublicAddr.SetString(g_sPublicIPAddress, false, true);
}
Expand Down