Skip to content

Conversation

@eNotchy
Copy link
Contributor

@eNotchy eNotchy commented Oct 30, 2025

@borkdude
Copy link
Member

@eNotchy Should we also add a function for integer? that is used in these core fns?

@borkdude borkdude merged commit ee16796 into squint-cljs:main Oct 30, 2025
3 checks passed
@eNotchy
Copy link
Contributor Author

eNotchy commented Oct 30, 2025

@eNotchy Should we also add a function for integer? that is used in these core fns?

yeah why not. How about this:

function integer_QMARK_(x) {
  return typeof x == 'bigint' || int_QMARK_(x);
}

@borkdude
Copy link
Member

It turned out it was already added.

@borkdude
Copy link
Member

@eNotchy Why did you have the typeof checks before Number.isInteger, those didn't seem to be necessary? I made some simplifications to that and the tests still seemed to work.

@eNotchy
Copy link
Contributor Author

eNotchy commented Oct 30, 2025

@eNotchy Why did you have the typeof checks before Number.isInteger, those didn't seem to be necessary? I made some simplifications to that and the tests still seemed to work.

You're right, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants