Skip to content

Equalent go benchmark#12

Merged
squeaky-pl merged 1 commit into
squeaky-pl:masterfrom
heppu:master
Feb 2, 2017
Merged

Equalent go benchmark#12
squeaky-pl merged 1 commit into
squeaky-pl:masterfrom
heppu:master

Conversation

@heppu
Copy link
Copy Markdown
Contributor

@heppu heppu commented Feb 1, 2017

Fixes for #11

@squeaky-pl
Copy link
Copy Markdown
Owner

squeaky-pl commented Feb 1, 2017

Hi, thanks for the PR. Have you managed to measure more or less what kind of speedup it makes over the previous version?

@heppu
Copy link
Copy Markdown
Contributor Author

heppu commented Feb 1, 2017

I haven't run benchmarks yet. Could you provide commands you used to run your benchmarks? Unrelated to performance, the go code in PR is little bit cleaner and easier to read so even though the performance wouldn't increase significantly. =)

Edit: Oh you had the wrk stuf in misc folder, my bad. I will run the test. =)

@squeaky-pl
Copy link
Copy Markdown
Owner

Great. Note that I run wrk 10 times in a row with -t 1-c 100 -d 2 and pipeline.lua script and took a median

@heppu
Copy link
Copy Markdown
Contributor Author

heppu commented Feb 1, 2017

Ok I ran the benchmark on the go version is 18% faster that the current go version on my machine.

@squeaky-pl
Copy link
Copy Markdown
Owner

waiting for go-fasthttp results and gonna put an errata in the article.

@heppu
Copy link
Copy Markdown
Contributor Author

heppu commented Feb 1, 2017

Oh sorry I forgot to set GOMAXPROCS=1. The increase was ~12% with that setup. I gotta say that that kind of takes away the advantage of Go but still is valid if you are planning to run http server on single thread instance :D

@squeaky-pl squeaky-pl merged commit b8c4dd7 into squeaky-pl:master Feb 2, 2017
@squeaky-pl squeaky-pl mentioned this pull request Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants