FEATURE: allow disabling private IPs #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry, might be a while before I can test it. Might be next weekend |
squat
approved these changes
Mar 3, 2021
Owner
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
Looks very non-invasive to me :)
When forcing the internal IP to "" or "-", private IPs won't be used.
leonnicolas
force-pushed
the
disable_private_ip
branch
from
f8a9597 to
9d10d4a
Compare
Owner
|
tested this on our clusters and it is working 🎉 |
squat
approved these changes
Mar 24, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When forcing the internal IP to "" or "-" with the force-internal-ip annotation, private IPs won't be used.
Nodes that have the annotation will be put in their own location: e.g.: "node:node-name". Then they will try to use WireGuard to connect to other nodes' endpoints in the cluster over their public interface. This only works, if the kubelet of the respected nodes can still connect to the API server over a public endpoint. If the kubelet uses a private IP to connect to the API server, Kilo will create routes so that the kubelet's request to the API server will go over the WireGuard interface. This leading to the node being not ready, if the API server's node has not set up the WireGurad config correctly. Anyways, trying to encrypt API server communication over Kilo's WireGuard sounds like a hen egg problem.
@SerialVelocity I don't have any device with a private and public interface. Could you test this?