feat: ObservableScreen view controller preferences#345
Merged
Conversation
watt
force-pushed
the
awatt/observable-screen-options
branch
from
b3a0c77 to
13225a8
Compare
watt
force-pushed
the
awatt/observable-screen-options
branch
from
13225a8 to
898e3f0
Compare
watt
commented
May 14, 2025
| /// (`setNeedsUpdateOfSupportedInterfaceOrientations()`), and rotates to a supported interface orientation if the | ||
| /// associated `view.window?.rootViewController?.supportedInterfaceOrientations` mask does not contain match the | ||
| /// current `windowScene` orientation. | ||
| public func setNeedsUpdateOfSupportedInterfaceOrientationsAndRotateIfNeeded() { |
Contributor
Author
There was a problem hiding this comment.
implementation copied verbatim from MarketScreen
johnnewman-square
approved these changes
May 16, 2025
Contributor
johnnewman-square
left a comment
johnnewman-square
left a comment
There was a problem hiding this comment.
Nice! Lots of new customization knobs here.
Co-authored-by: johnnewman-square <johnnewman@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a bunch of optional methods to the
ObservableScreenprotocol to customize view controller behavior:Checklist