Return FunSpec.Builder from jvmModifiers to not break chaining#2004
Open
Return FunSpec.Builder from jvmModifiers to not break chaining#2004
Conversation
Egorand
force-pushed
the
egor.241015.jvm-modifiers-builder
branch
from
6c3b3ba to
c41edf9
Compare
JakeWharton
reviewed
Oct 15, 2024
Collaborator
JakeWharton
left a comment
JakeWharton
left a comment
There was a problem hiding this comment.
This breaks binary compatibility. We need to retain the old signature and use @JvmName on the new one.
Collaborator
Author
|
The plan is to ship this as part of 2.0, or 3.0, or do you think we shouldn't be breaking binary compat regardless? I'd actually like to clean up some deprecated APIs in either 2.0 or 3.0. |
Collaborator
|
I definitely would not break anything for 2.0. The sole behavior change is the wrapping change, though that doesn't break anything. In 3.0 we could move deprecations to be hidden. I don't want someone to have a reason not to upgrade due to compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #638.
docs/changelog.mdhas been updated if applicable.be added to the changelog.