The change names containing `]` are not parsed correctly when used as dependencies

[brokenpylons]

For example:

%syntax-version=1.0.0
%project=test

testa[test]test 2024-05-23T11:14:35Z Žiga Leber <mail+github@zigaleber.com> # Add schema
testb [testa[test]test] 2024-05-23T11:16:00Z Žiga Leber <mail+github@zigaleber.com> # Something

This fails with:

Syntax error in sqitch.plan at line 5: Invalid name; names must not begin with punctuation, contain "@", ":", "#", "\", or blanks, or end in punctuation or digits following punctuation

The issue arises due to, the regex assumes the dependencies cannot contain ]. The example is then parsed as testb [testa[test] followed by test].

The easiest solution would be to revise the rule to: All other characters may be any UTF-8 character other than “:”, “@”, “#”, “\” and "]".

[theory]

Replicating the issue:

$ sqitch init try --engine sqlite
Created sqitch.conf
Created sqitch.plan
Created deploy/
Created revert/
Created verify/

$ sqitch add 'testa[test]test' -m 'Test'
Created deploy/testa[test]test.sql
Created revert/testa[test]test.sql
Created verify/testa[test]test.sql
Added "testa[test]test" to sqitch.plan

$ sqitch add testb --requires 'testa[test]test' -m test2
Created deploy/testb.sql
Created revert/testb.sql
Created verify/testb.sql
Added "testb [testa[test]test]" to sqitch.plan

$ sqitch deploy db:sqlite:try.db                        
Syntax error in sqitch.plan at line 5: Invalid name; names must not begin with punctuation, contain "@", ":", "#", "\", or blanks, or end in punctuation or digits following punctuation

[theory]

Wow, quite the find. Probably should ban brackets in change names as you suggest. It might be possible to allow them by updating the parser to look for an additional closing bracket at the end, but likely to be a PITA.

[theory]

Fix released in v1.5.0.