Open
Conversation
|
I think it would be better if the option was removed, and instead it would validate like so:
Reason being because different wallets will do it differently, and app developers shouldn't have to think about which one the wallet happens to use. Perhaps the flag could be used if the developer KNOWS that it needs to be ERC-55, but this is probably quite rare. But does this require a major version bump since the behavior changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The SIWE message constructor throws if the address isn't EIP55 compliant, which brakes the SIWE integration for users that use wallets such as Zerion.
In addition to that, it's not a hard requirement based on the EIP-4361 spec
This provides flexibility to developers to decide whatever or not they want explicit EIP55 validation.
The option defaults to
trueand is optional for backwards compatibility.