Conversation
tolak
commented
Feb 15, 2023
tolak
commented
freddyli7
left a comment
freddyli7
left a comment
There was a problem hiding this comment.
LGTM! just one question
| { | ||
| /// Pause bridge, this would lead to bridge transfer failure before it being unpaused. | ||
| #[pallet::weight(195_000_000)] | ||
| #[pallet::call_index(0)] |
There was a problem hiding this comment.
I see now we have this call_index annotation in v0.9.37, is it a mandatory annotation for each extrinsic now from this version? I remember that when we worked on the access grant feature, we used to define a number for each extrinsic, then we decided to use a more readable and maintainable name, is this annotation related to that number?
There was a problem hiding this comment.
Yes, it is used to identify the extrinsic. We were planning to use the index but we thought the index may change. I have short discuss with parity team when they implement this function, suggested to add name too but they don't think runtime should care about the name, see here
2 participants
