Commit Session on Include Dispatch calls commitSession each time

[laurentschoelens]

This provides a fix proposal for #2284

It marks the current request that a first-commit has been done in a include context to not commit on every requestDispatcher.include call

[laurentschoelens]

Tested successfully on my app.

Before fix, JFR results :

After fix, JFR results :

[laurentschoelens]

I've not been able to run all tests on my laptop and not found information on how to do it on documentation.

[marcusdacoregio]

Hi @laurentschoelens, we are gonna consider this as an enhancement since the code is running as expected and this is a performance enhancement. Can you rebase your branch off of main and also add a test to make sure the session is not committed again? Ideally, the test should fail without your changes and pass with them.

[laurentschoelens]

Hi @marcusdacoregio : hope done well :)
I've added one unit test that fails with actual code and pass with my changes.
Since SpringBoot 2.7 is still in maintenance, could I hope to have it backported to latest 2.X branch ?

[laurentschoelens]

@marcusdacoregio seen that build failed due to checkstyle violation on my new unit test 😔

[marcusdacoregio]

Don't worry @laurentschoelens, I can take care of it before merging

[marcusdacoregio]

Thanks @laurentschoelens, this is now merged into main via 7360723 with this polish commit 2d43c31