Make OAuth2User extends OAuth2AuthenticatedPrincipal#7383
Merged
jzheaux merged 1 commit intospring-projects:masterfrom Sep 9, 2019
Merged
Make OAuth2User extends OAuth2AuthenticatedPrincipal#7383jzheaux merged 1 commit intospring-projects:masterfrom
jzheaux merged 1 commit intospring-projects:masterfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Sep 6, 2019
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks for this, @eddumelendez! I've left just one piece of feedback inline.
oauth2/oauth2-core/src/main/java/org/springframework/security/oauth2/core/user/OAuth2User.java
Outdated
Show resolved
Hide resolved
jzheaux
added
in: oauth2
eddumelendez
force-pushed
the
gh-7378
branch
from
e0a8d87 to
ccd0458
Compare
jgrandja
reviewed
Sep 8, 2019
...g/springframework/security/oauth2/client/userinfo/CustomUserTypesOAuth2UserServiceTests.java
Outdated
Show resolved
Hide resolved
jgrandja
reviewed
Sep 8, 2019
.../java/org/springframework/security/oauth2/client/userinfo/DefaultOAuth2UserServiceTests.java
Outdated
Show resolved
Hide resolved
jgrandja
reviewed
Sep 8, 2019
...g/springframework/security/oauth2/client/userinfo/DefaultReactiveOAuth2UserServiceTests.java
Outdated
Show resolved
Hide resolved
eddumelendez
force-pushed
the
gh-7378
branch
from
ccd0458 to
e35ea2d
Compare
Contributor
Author
|
Thanks @jgrandja ! I have updated the PR |
jzheaux
approved these changes
Sep 9, 2019
Contributor
|
Thanks, @eddumelendez, this is now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-7378