Fix infinite loop in role hierarchy resolving#7106
Merged
rwinch merged 3 commits intospring-projects:masterfrom Jul 23, 2019
Merged
Fix infinite loop in role hierarchy resolving#7106rwinch merged 3 commits intospring-projects:masterfrom
rwinch merged 3 commits intospring-projects:masterfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thanks for the PR @karelmaxa! This is now merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue with infinite loop in role hierarchy resolving.
The original issue has been resolved in first two commits (
2d36062,d3eaef6). Last commit (be0ad67) simplifies the implementation in general meaning and removes unnecessary logic (logic related to the comparison of customGrantedAuthorityimplementations). We are convinced that the readability of the component is much more better, but it is not necessary to merge this commit as well.Fixes gh-7035