Fixed validation in ClientRegistration.Builder#7047
Merged
rwinch merged 1 commit intospring-projects:masterfrom Jul 3, 2019
Merged
Fixed validation in ClientRegistration.Builder#7047rwinch merged 1 commit intospring-projects:masterfrom
rwinch merged 1 commit intospring-projects:masterfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
requested changes
Jun 28, 2019
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR @edouardhue!
I don't think we want to make OAuth2AuthorizationGrantRequestEntityUtils public because it wasn't really designed for external usage.
If we did make such a change, we'd want to do this in a separate ticket. Can you please remove the public modifier changes and we can get this merged? Then we can discuss on a separate ticket what exactly you are needing.
rwinch
added
status: waiting-for-feedback
ClientRegistration.Builder defaulted to validating as an authorization_code registration, though a custom grant type could be in use. The actual grant_type is now verified for every case. - Fixed validation in ClientRegistration.Builder - New test that fails unless the issue is fixed. Also made OAuth2AuthorizationGrantRequestEntityUtils public to help implementing custom token response clients. Fixes gh-7040
Contributor
Author
|
@rwinch Ok, that's undone. I'll consider another ticket for this need. |
spring-projects-issues
added
status: feedback-provided
rwinch
added
in: oauth2
rwinch
approved these changes
Jul 3, 2019
Member
|
Thanks for the updates @edouardhue! This is now merged into master and backported to 5.1.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientRegistration.Builder defaulted to validating as an
authorization code registration, though a custom grant type could be in
use. The actual grant type is now verified for every case.
Also made OAuth2AuthorizationGrantRequestEntityUtils public to help
implementing custom token response clients.
Fixes #7040