Move log statement in SessionRegistryImpl#6979
Merged
rwinch merged 1 commit intospring-projects:masterfrom Jun 13, 2019
jbrokamp:patch-1
Merged
Move log statement in SessionRegistryImpl#6979rwinch merged 1 commit intospring-projects:masterfrom jbrokamp:patch-1
rwinch merged 1 commit intospring-projects:masterfrom
jbrokamp:patch-1
Conversation
Moved after removeSessionInformation() is called for comprehensible output to log file. The log statements are now written in correct order. Before the change, this could be confusing when debugging an application, since it seemed that the registered session was immediately removed when only looking at the logs.
|
@joos-edia Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@joos-edia Thank you for signing the Contributor License Agreement! |
Member
|
Thanks for the PR @joos-edia! This is now merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved a log statement in
SessionRegistryImpl#registerNewSessionafterremoveSessionInformation()is called for comprehensible output to the logger.The log statements are now printed in the same order as the logic is executed. Before the change, this could be confusing when debugging an application, since it seemed that the registered session was immediately removed when only looking at the logs.
Before:
After:
NB: I did not create a ticket for this.