OAuth2LoginAuthenticationFilter sets AuthenticationDetails#6884
Merged
rwinch merged 1 commit intospring-projects:masterfrom Jun 17, 2019
ddevrien:gh-6866-oauth2-login-auth-details
Merged
OAuth2LoginAuthenticationFilter sets AuthenticationDetails#6884rwinch merged 1 commit intospring-projects:masterfrom ddevrien:gh-6866-oauth2-login-auth-details
rwinch merged 1 commit intospring-projects:masterfrom
ddevrien:gh-6866-oauth2-login-auth-details
Conversation
|
@ddevrien Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ddevrien Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: oauth2
rwinch
changed the title
rwinch
requested changes
May 17, 2019
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR @ddevrien! Can you please update to match the proper commit message format? For example something like this:
OAuth2LoginAuthenticationFilter sets AuthenticationDetails
Fixes gh-6866
Contributor
Author
|
@rwinch let me know if I need to change anything else :) |
rwinch
approved these changes
Jun 17, 2019
Member
|
Thanks for the PR @ddevrien! This is now fixed in master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[GH-6866] OAuth2LoginAuthenticationFilter should set AuthenticationDetails