Properties should reference scope not scopes#6510
Properties should reference scope not scopes#6510sdoxsee wants to merge 1 commit intospring-projects:masterfrom
Conversation
|
Thanks for the PR @sdoxsee. Would you be able to update the same in |
|
done. Thanks! |
|
Thanks @sdoxsee It looks like there are few additional places. Can you update the PR to get those as well? Here are all the places I found with a quick search: $ rg "scopes: "
samples/boot/oauth2webclient-webflux/README.adoc
43: scopes: read:user,public_repo
samples/boot/oauth2webclient/README.adoc
43: scopes: read:user,public_repo
samples/boot/oauth2webclient/src/main/resources/application.yml
19: scopes: read:user,public_repo
samples/boot/oauth2webclient-webflux/src/main/resources/application.yml
19: scopes: read:user,public_repo
docs/manual/src/docs/asciidoc/_includes/reactive/oauth2/access-token.adoc
17: scopes: read:user,public_repo |
|
Thanks @rwinch. I've got those now as well. Would it make more sense to change the |
|
@sdoxsee In regards to...
The name The changes look great in this PR and it's ready to get merged. Can you please squash to 1 commit and ensure the commit message follows this format and includes |
OAuth2ClientProperties.Registration (which captures .properties and .yml for OAuth2 Client) has a member `scope` but not `scopes`. Samples and documentation were using `scopes` and have now been updated to use `scope`. Fixes spring-projectsgh-6510
jgrandja
added
in: docs
|
Thanks for the PR @sdoxsee! This is now in master. |
OAuth2ClientProperties.Registration (which captures .properties and .yml for OAuth2 Client) has a member `scope` but not `scopes`. Samples and documentation were using `scopes` and have now been updated to use `scope`. Fixes gh-6510
|
Awesome. Thanks @jgrandja |
3 participants
OAuth2ClientProperties.Registration has a member
scopebut notscopes. This is the easy fix for the sample but i think it should bescopes