Add Reactive Support for UserDetailsChecker#6229
Merged
rwinch merged 1 commit intospring-projects:masterfrom Dec 11, 2018
edeandrea:gh-6219
Merged
Add Reactive Support for UserDetailsChecker#6229rwinch merged 1 commit intospring-projects:masterfrom edeandrea:gh-6219
rwinch merged 1 commit intospring-projects:masterfrom
edeandrea:gh-6219
Conversation
rwinch
requested changes
Dec 5, 2018
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have replied inline
...ingframework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManager.java
Outdated
Show resolved
Hide resolved
...ingframework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManager.java
Outdated
Show resolved
Hide resolved
...ity/oauth2/server/resource/authentication/JwtUserDetailsCheckingAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...h2/server/resource/authentication/ReactiveJwtUserDetailsCheckingAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...auth2/server/resource/authentication/JwtUserDetailsCheckingAuthenticationConverterTests.java
Outdated
Show resolved
Hide resolved
...rver/resource/authentication/ReactiveJwtUserDetailsCheckingAuthenticationConverterTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I made the requested changes & rebased the commits into a single commit. I'll open a separate ticket for the |
Contributor
Author
|
I opened #6237 for the other part of what I removed from this PR. |
rwinch
requested changes
Dec 6, 2018
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the the fast turnaround. I have provided additional feedback inline
...amework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManagerTests.java
Outdated
Show resolved
Hide resolved
...amework/security/authentication/UserDetailsRepositoryReactiveAuthenticationManagerTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Added a new commit with requested changes. |
rwinch
requested changes
Dec 7, 2018
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR @edeandrea! Can you please squash your commits and change the commit subject to be a little more descriptive? Something like Add Reactive Support for UserDetailsChecker
rwinch
added
the
status: waiting-for-feedback
Integrate UserDetailsChecker into ReactiveAuthenticationManager and OAuth2 resource server authentication converters. Fixes gh-6219
Contributor
Author
|
Done! |
rwinch
changed the title
rwinch
removed
the
status: waiting-for-feedback
rwinch
approved these changes
Dec 11, 2018
rwinch
added
status: duplicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate UserDetailsChecker into ReactiveAuthenticationManager and
OAuth2 resource server authentication converters.
Fixes gh-6219